class RuboCop::Cop::Style::RedundantCondition
end
c
elsif cond
b
if b
# good
b || c
# good
end
c
else
b
if b
# bad
@example
a = b || c
# good
a = b ? b : c
# bad
@example
Checks for unnecessary conditional expressions.
def argument_with_operator?(argument)
If the argument is using an operator, it is an invalid syntax.
def argument_with_operator?(argument) return true if ARGUMENT_WITH_OPERATOR_TYPES.include?(argument.type) return false unless argument.hash_type? return false unless (node = argument.children.first) node.kwsplat_type? || node.forwarded_kwrestarg_type? end
def asgn_type?(node)
def asgn_type?(node) node.lvasgn_type? || node.ivasgn_type? || node.cvasgn_type? || node.gvasgn_type? end
def branches_have_assignment?(node)
def branches_have_assignment?(node) _condition, if_branch, else_branch = *node return false unless if_branch && else_branch asgn_type?(if_branch) && (if_branch_variable_name = if_branch.name) && asgn_type?(else_branch) && (else_branch_variable_name = else_branch.name) && if_branch_variable_name == else_branch_variable_name end
def branches_have_method?(node)
def branches_have_method?(node) _condition, if_branch, else_branch = *node return false unless if_branch && else_branch single_argument_method?(if_branch) && single_argument_method?(else_branch) && same_method?(if_branch, else_branch) end
def correct_ternary(corrector, node)
def correct_ternary(corrector, node) corrector.replace(range_of_offense(node), '||') return unless node.else_branch.range_type? corrector.wrap(node.else_branch, '(', ')') end
def else_source(else_branch, arithmetic_operation) # rubocop:disable Metrics/AbcSize
def else_source(else_branch, arithmetic_operation) # rubocop:disable Metrics/AbcSize if arithmetic_operation "#{else_branch.first_argument.source})" elsif branches_have_method?(else_branch.parent) else_source_if_has_method(else_branch) elsif require_parentheses?(else_branch) "(#{else_branch.source})" elsif without_argument_parentheses_method?(else_branch) "#{else_branch.method_name}(#{else_branch.arguments.map(&:source).join(', ')})" elsif branches_have_assignment?(else_branch.parent) else_source_if_has_assignment(else_branch) else else_branch.source end end
def else_source_if_has_assignment(else_branch)
def else_source_if_has_assignment(else_branch) if require_parentheses?(else_branch.expression) "(#{else_branch.expression.source})" elsif require_braces?(else_branch.expression) "{ #{else_branch.expression.source} }" else else_branch.expression.source end end
def else_source_if_has_method(else_branch)
def else_source_if_has_method(else_branch) if require_parentheses?(else_branch.first_argument) "(#{else_branch.first_argument.source})" elsif require_braces?(else_branch.first_argument) "{ #{else_branch.first_argument.source} }" else else_branch.first_argument.source end end
def if_source(if_branch, arithmetic_operation)
def if_source(if_branch, arithmetic_operation) if branches_have_method?(if_branch.parent) && if_branch.parenthesized? if_branch.source.delete_suffix(')') elsif arithmetic_operation argument_source = if_branch.first_argument.source "#{if_branch.receiver.source} #{if_branch.method_name} (#{argument_source}" else if_branch.source end end
def make_ternary_form(node)
def make_ternary_form(node) _condition, if_branch, else_branch = *node arithmetic_operation = use_arithmetic_operation?(if_branch) ternary_form = [ if_source(if_branch, arithmetic_operation), else_source(else_branch, arithmetic_operation) ].join(' || ') ternary_form += ')' if branches_have_method?(node) && if_branch.parenthesized? if node.parent&.send_type? "(#{ternary_form})" else ternary_form end end
def message(node)
def message(node) if redundant_condition?(node) REDUNDANT_CONDITION else MSG end end
def offense?(node)
def offense?(node) _condition, _if_branch, else_branch = *node return false if use_if_branch?(else_branch) || use_hash_key_assignment?(else_branch) synonymous_condition_and_branch?(node) && !node.elsif? && (node.ternary? || !else_branch.instance_of?(AST::Node) || else_branch.single_line?) end
def on_if(node)
def on_if(node) return if node.elsif_conditional? return unless offense?(node) message = message(node) add_offense(range_of_offense(node), message: message) do |corrector| if node.ternary? && !branches_have_method?(node) correct_ternary(corrector, node) elsif redundant_condition?(node) corrector.replace(node, node.if_branch.source) else corrected = make_ternary_form(node) corrector.replace(node, corrected) end end end
def range_of_offense(node)
def range_of_offense(node) return node.source_range unless node.ternary? return node.source_range if node.ternary? && branches_have_method?(node) range_between(node.loc.question.begin_pos, node.loc.colon.end_pos) end
def redundant_condition?(node)
def redundant_condition?(node) node.modifier_form? || !node.else_branch end
def require_braces?(node)
def require_braces?(node) node.hash_type? && !node.braces? end
def require_parentheses?(node)
def require_parentheses?(node) (node.basic_conditional? && node.modifier_form?) || node.range_type? || node.rescue_type? || (node.respond_to?(:semantic_operator?) && node.semantic_operator?) end
def same_method?(if_branch, else_branch)
def same_method?(if_branch, else_branch) if_branch.method?(else_branch.method_name) && if_branch.receiver == else_branch.receiver end
def single_argument_method?(node)
def single_argument_method?(node) return false if !node.send_type? || node.method?(:[]) || !node.arguments.one? !argument_with_operator?(node.first_argument) end
def synonymous_condition_and_branch?(node)
def synonymous_condition_and_branch?(node) condition, if_branch, _else_branch = *node # e.g. # if var # var # else # 'foo' # end return true if condition == if_branch # e.g. # if foo # @value = foo # else # @value = another_value? # end return true if branches_have_assignment?(node) && condition == if_branch.expression # e.g. # if foo # test.value = foo # else # test.value = another_value? # end branches_have_method?(node) && condition == if_branch.first_argument && !use_hash_key_access?(if_branch) end
def use_arithmetic_operation?(node)
def use_arithmetic_operation?(node) node.respond_to?(:arithmetic_operation?) && node.arithmetic_operation? end
def use_hash_key_access?(node)
def use_hash_key_access?(node) node.send_type? && node.method?(:[]) end
def use_hash_key_assignment?(else_branch)
def use_hash_key_assignment?(else_branch) else_branch&.send_type? && else_branch&.method?(:[]=) end
def use_if_branch?(else_branch)
def use_if_branch?(else_branch) else_branch&.if_type? end
def without_argument_parentheses_method?(node)
def without_argument_parentheses_method?(node) node.send_type? && !node.arguments.empty? && !node.parenthesized? && !node.operator_method? && !node.assignment_method? end