class RuboCop::Cop::Rails::FindBy
User.find_by(name: ‘Bruce’)
# good
User.where(name: ‘Bruce’).take
User.where(name: ‘Bruce’).first
# bad
@example
change them to use ‘find_by` instead.
This cop is used to identify usages of `where.first` and
def autocorrect(node)
def autocorrect(node) # Don't autocorrect where(...).first, because it can return different # results from find_by. (They order records differently, so the # 'first' record can be different.) return if node.method?(:first) where_loc = node.receiver.loc.selector first_loc = range_between(node.loc.dot.begin_pos, node.loc.selector.end_pos) lambda do |corrector| corrector.replace(where_loc, 'find_by') corrector.replace(first_loc, '') end end
def on_send(node)
def on_send(node) return unless where_first?(node) range = range_between(node.receiver.loc.selector.begin_pos, node.loc.selector.end_pos) add_offense(node, location: range, message: format(MSG, method: node.method_name)) end