class RuboCop::Cop::RSpec::ScatteredSetup
end
end
setup2
setup1
before do
describe Foo do
# good
end
before { setup2 }
before { setup1 }
describe Foo do
# bad
@example
Unify ‘before`, `after`, and `around` hooks when possible.
Checks for setup scattered across multiple hooks in an example group.
def lines_msg(numbers)
def lines_msg(numbers) if numbers.size == 1 "line #{numbers.first}" else "lines #{numbers.join(', ')}" end end
def on_block(node)
def on_block(node) return unless example_group?(node) repeated_hooks(node).each do |occurrences| lines = occurrences.map(&:first_line) occurrences.each do |occurrence| lines_except_current = lines - [occurrence.first_line] message = format(MSG, hook_name: occurrences.first.method_name, lines: lines_msg(lines_except_current)) add_offense(occurrence, message: message) end end end
def repeated_hooks(node)
def repeated_hooks(node) hooks = RuboCop::RSpec::ExampleGroup.new(node) .hooks .select(&:knowable_scope?) .group_by { |hook| [hook.name, hook.scope, hook.metadata] } .values .reject(&:one?) hooks.map do |hook| hook.map(&:to_node) end end