class RuboCop::Cop::Lint::NonLocalExitFromIterator
end
end
end
end
item.update!(foobar: true)
return if item.stock == 0 # false-negative…
find_each do |item| # block without method chain
return unless update_necessary? # allowed
transaction do # block without arguments
def update_items
end
message: ‘validation error’, errors: error_array
end
“#{error.param}: #{error.message}”
return “#{error.param}: invalid” unless error.message # allowed
return if error.suppress? # warned
error_array = e.errors.map do |error| # block with method chain
return message: ‘validation error’ unless e.errors # allowd
rescue_from ValidationError do |e| # non-iteration block with arg
class ItemApi
@example
value, block followed by method chain, and block have arguments.
It warns only when satisfies all of these: ‘return` doesn’t have return
This cop checks for non-local exit from iterator, without return value.
def chained_send?(send_node)
def chained_send?(send_node) receiver_node, _selector_node = *send_node !receiver_node.nil? end
def lambda?(send_node)
def lambda?(send_node) receiver_node, selector_node = *send_node receiver_node.nil? && selector_node == :lambda end
def on_return(return_node)
def on_return(return_node) return if return_value?(return_node) return_node.each_ancestor(:block) do |block_node| send_node, args_node, _body_node = *block_node # `return` does not exit to outside of lambda block, this is safe. break if lambda?(send_node) next if args_node.children.empty? if chained_send?(send_node) add_offense(return_node, :keyword) break end end end
def return_value?(return_node)
def return_value?(return_node) !return_node.children.empty? end