class RuboCop::Cop::Style::IfUnlessModifier
The maximum line length is configurable.
if written as a modifier if/unless.
Checks for if and unless statements that would fit on one line
def autocorrect(node)
def autocorrect(node) ->(corrector) { corrector.replace(node.source_range, oneline(node)) } end
def first_line_comment(node)
def first_line_comment(node) comment = processed_source.comments.find { |c| c.loc.line == node.loc.line } comment ? comment.loc.expression.source : nil end
def message(keyword)
def message(keyword) "Favor modifier `#{keyword}` usage when having a single-line body." \ ' Another good alternative is the usage of control flow `&&`/`||`.' end
def method_uses_parens?(node, limit)
def method_uses_parens?(node, limit) source = node.source_range.source_line[0...limit.loc.column] source =~ /\s*\(\s*$/ end
def nested_conditional?(node)
def nested_conditional?(node) node.children[1, 2].any? { |child| child && child.type == :if } end
def on_if(node)
def on_if(node) # discard ternary ops, if/else and modifier if/unless nodes return if ternary?(node) return if modifier_if?(node) return if elsif?(node) return if if_else?(node) return if node.chained? return unless fit_within_line_as_modifier_form?(node) return if nested_conditional?(node) add_offense(node, :keyword, message(node.loc.keyword.source)) end
def oneline(node)
def oneline(node) cond, body, _else = if_node_parts(node) expr = "#{body.source} #{node.loc.keyword.source} " + cond.source if (comment_after = first_line_comment(node)) expr << ' ' << comment_after end expr = "(#{expr})" if parenthesize?(node) expr end
def parenthesize?(node)
def parenthesize?(node) # Parenthesize corrected expression if changing to modifier-if form # would change the meaning of the parent expression # (due to the low operator precedence of modifier-if) return false if node.parent.nil? return true if ASSIGNMENT_TYPES.include?(node.parent.type) if node.parent.send_type? _receiver, _name, *args = *node.parent return !method_uses_parens?(node.parent, args.first) end false end