class RuboCop::Cop::Performance::StringReplacement
‘a b c’.delete(‘ ’)
‘abc’.tr(‘b’, ‘d’)
‘abc’.gsub(/a+/, ‘d’)
‘abc’.gsub(/.*/, ‘a’)
@good
’abc’.gsub!(‘a’, ‘d’)
‘abc’.gsub(/a/, ‘d’)
‘abc’.gsub(‘a’, ”)
‘abc’.gsub(‘b’, ‘d’)
@bad
@example
`tr` or ‘delete`.
This cop identifies places where `gsub` can be replaced by
def accept_first_param?(first_param)
def accept_first_param?(first_param) first_source, options = first_source(first_param) return true if first_source.nil? unless first_param.str_type? return true if options return true unless first_source =~ DETERMINISTIC_REGEX # This must be done after checking DETERMINISTIC_REGEX # Otherwise things like \s will trip us up first_source = interpret_string_escapes(first_source) end first_source.length != 1 end
def accept_second_param?(second_param)
def accept_second_param?(second_param) second_source, = *second_param second_source.length > 1 end
def autocorrect(node)
def autocorrect(node) _string, method, first_param, second_param = *node first_source, = first_source(first_param) second_source, = *second_param unless first_param.str_type? first_source = interpret_string_escapes(first_source) end replacement_method = replacement_method(method, first_source, second_source) replace_method(node, first_source, second_source, first_param, replacement_method) end
def bang_method?(method)
def bang_method?(method) method.to_s.end_with?(BANG) end
def first_source(first_param)
def first_source(first_param) case first_param.type when :regexp source_from_regex_literal(first_param) when :send source_from_regex_constructor(first_param) when :str first_param.children.first end end
def message(method, first_source, second_source)
def message(method, first_source, second_source) replacement_method = replacement_method(method, first_source, second_source) format(MSG, replacement_method, method) end
def method_suffix(node)
def method_suffix(node) node.loc.end ? node.loc.end.source : '' end
def offense(node, method, first_param, second_param)
def offense(node, method, first_param, second_param) first_source, = first_source(first_param) unless first_param.str_type? first_source = interpret_string_escapes(first_source) end second_source, = *second_param message = message(method, first_source, second_source) add_offense(node, range(node), message) end
def on_send(node)
def on_send(node) string_replacement?(node) do |method, first_param, second_param| return if accept_second_param?(second_param) return if accept_first_param?(first_param) offense(node, method, first_param, second_param) end end
def range(node)
def range(node) range_between(node.loc.selector.begin_pos, node.source_range.end_pos) end
def remove_second_param(corrector, node, first_param)
def remove_second_param(corrector, node, first_param) end_range = range_between(first_param.source_range.end_pos, node.source_range.end_pos) corrector.replace(end_range, method_suffix(node)) end
def replace_method(node, first, second, first_param, replacement)
def replace_method(node, first, second, first_param, replacement) lambda do |corrector| corrector.replace(node.loc.selector, replacement) unless first_param.str_type? corrector.replace(first_param.source_range, to_string_literal(first)) end if second.empty? && first.length == 1 remove_second_param(corrector, node, first_param) end end end
def replacement_method(method, first_source, second_source)
def replacement_method(method, first_source, second_source) replacement = if second_source.empty? && first_source.length == 1 DELETE else TR end "#{replacement}#{BANG if bang_method?(method)}" end
def source_from_regex_constructor(node)
def source_from_regex_constructor(node) _const, _init, regex = *node case regex.type when :regexp source_from_regex_literal(regex) when :str source, = *regex source end end
def source_from_regex_literal(node)
def source_from_regex_literal(node) regex, options = *node source, = *regex options, = *options [source, options] end