class RuboCop::Cop::Style::Alias
It also finds uses of ‘alias :symbol` rather than `alias bareword`.
versa.
appropriate (or is simply preferred due to configuration), and vice
This cop finds uses of `alias` where `alias_method` would be more
def add_offense_for_args(node)
def add_offense_for_args(node) existing_args = node.children.map(&:source).join(' ') preferred_args = node.children.map { |a| a.source[1..-1] }.join(' ') arg_ranges = node.children.map(&:source_range) msg = format(MSG_SYMBOL_ARGS, preferred_args, existing_args) add_offense(node, arg_ranges.reduce(&:join), msg) end
def autocorrect(node)
def autocorrect(node) if node.send_type? correct_alias_method_to_alias(node) elsif scope_type(node) == :dynamic || style == :prefer_alias_method correct_alias_to_alias_method(node) else correct_alias_with_symbol_args(node) end end
def bareword?(sym_node)
def bareword?(sym_node) !sym_node.source.start_with?(':') end
def correct_alias_method_to_alias(send_node)
def correct_alias_method_to_alias(send_node) lambda do |corrector| new, old = *send_node.arguments replacement = "alias #{new.children.first} #{old.children.first}" corrector.replace(send_node.source_range, replacement) end end
def correct_alias_to_alias_method(node)
def correct_alias_to_alias_method(node) lambda do |corrector| new, old = *node replacement = "alias_method :#{new.children.first}, " \ ":#{old.children.first}" corrector.replace(node.source_range, replacement) end end
def correct_alias_with_symbol_args(node)
def correct_alias_with_symbol_args(node) lambda do |corrector| new, old = *node corrector.replace(new.source_range, new.children.first.to_s) corrector.replace(old.source_range, old.children.first.to_s) end end
def lexical_scope_type(node)
def lexical_scope_type(node) node.each_ancestor(:class, :module) do |ancestor| return ancestor.class_type? ? 'in a class body' : 'in a module body' end 'at the top level' end
def on_alias(node)
def on_alias(node) # alias_method can't be used with global variables return if node.each_child_node(:gvar).any? # alias_method can't be used in instance_eval blocks scope_type = scope_type(node) return if scope_type == :instance_eval if scope_type == :dynamic || style == :prefer_alias_method add_offense(node, :keyword, MSG_ALIAS) elsif node.children.none? { |arg| bareword?(arg) } add_offense_for_args(node) end end
def on_send(node)
def on_send(node) return unless node.command?(:alias_method) return if style == :prefer_alias_method return if scope_type(node) == :dynamic msg = format(MSG_ALIAS_METHOD, lexical_scope_type(node)) add_offense(node, :selector, msg) end
def scope_type(node)
class or module block (:lexical)? Or will it be something else
In this expression, will `self` be the same as the innermost enclosing
def scope_type(node) while (parent = node.parent) case parent.type when :class, :module return :lexical when :def, :defs return :dynamic when :block return :instance_eval if parent.method_name == :instance_eval return :dynamic end node = parent end :lexical end