class RuboCop::Cop::Lint::IneffectiveAccessModifier
end
end
end
puts ‘hi’
def method
private
class << self
class C
# good
@example
end
private_class_method :method
end
puts ‘hi’
def self.method
class C
# good
@example
end
end
puts ‘hi’
def self.method
private
class C
# bad
@example
used for that.
singleton methods private/protected. ‘private_class_method` can be
applied to a singleton method. These access modifiers do not make
This cop checks for `private` or `protected` access modifiers which are
def check_child_scope(node, cur_vis)
def check_child_scope(node, cur_vis) case node.type when :send cur_vis = check_send(node, cur_vis) when :defs check_defs(node, cur_vis) when :kwbegin check_scope(node, cur_vis) end cur_vis end
def check_defs(node, cur_vis)
def check_defs(node, cur_vis) mark_method_as_useless(node, cur_vis) if cur_vis != :public end
def check_node(node)
def check_node(node) return unless node && node.begin_type? clear check_scope(node) @useless.each do |_name, (defs_node, visibility, modifier)| add_offense(defs_node, :keyword, format_message(visibility, modifier)) end end
def check_scope(node, cur_vis = :public)
def check_scope(node, cur_vis = :public) node.children.reduce(cur_vis) do |visibility, child| check_child_scope(child, visibility) end end
def check_send(node, cur_vis)
def check_send(node, cur_vis) if node.access_modifier? && !node.method?(:module_function) @last_access_modifier = node return node.method_name elsif (methods = private_class_method(node)) # don't warn about defs nodes which are followed by a call to # `private_class_method :name` # obviously the programmer knows what they are doing revert_method_uselessness(methods) end cur_vis end
def clear
def clear @useless = {} @last_access_modifier = nil end
def format_message(visibility, modifier)
def format_message(visibility, modifier) alternative = if visibility == :private ALTERNATIVE_PRIVATE else ALTERNATIVE_PROTECTED end format(MSG, visibility, modifier.location.expression.line, visibility, alternative) end
def mark_method_as_useless(node, cur_vis)
def mark_method_as_useless(node, cur_vis) _, method_name, = *node @useless[method_name] = [node, cur_vis, @last_access_modifier] end
def on_class(node)
def on_class(node) check_node(node.children[2]) # class body end
def on_module(node)
def on_module(node) check_node(node.children[1]) # module body end
def revert_method_uselessness(methods)
def revert_method_uselessness(methods) methods.each do |sym| next unless sym.sym_type? @useless.delete(sym.children[0]) end end