class RuboCop::Cop::Style::MethodDefParentheses
end
do_something
last_descriptive_var_name)
another_descriptive_var_name,
def foo(descriptive_var_name,
end
num1 + num2
def bar num1, num2
# good
end
do_something
last_descriptive_var_name
another_descriptive_var_name,
def foo descriptive_var_name,
end
num1 + num2
def bar(num1, num2)
# bad
# but prefers parentheses when arguments span multiple lines.
# parentheses when method definition arguments fit on single line,
# The ‘require_no_parentheses_except_multiline` style prefers no
@example EnforcedStyle: require_no_parentheses_except_multiline
end
do_something
last_descriptive_var_name
another_descriptive_var_name,
def foo descriptive_var_name,
end
num1 + num2
def bar num1, num2
# good
end
do_something
last_descriptive_var_name)
another_descriptive_var_name,
def foo(descriptive_var_name,
end
num1 + num2
def bar(num1, num2)
# bad
# to never use parentheses
# The `require_no_parentheses` style requires method definitions
@example EnforcedStyle: require_no_parentheses
end
do_something
last_descriptive_var_name)
another_descriptive_var_name,
def foo(descriptive_var_name,
end
num1 + num2
def bar(num1, num2)
# good
end
do_something
last_descriptive_var_name
another_descriptive_var_name,
def foo descriptive_var_name,
end
num1 + num2
def bar num1, num2
# bad
# to always use parentheses
# The `require_parentheses` style requires method definitions
@example EnforcedStyle: require_parentheses (default)
definitions. Both instance and class/singleton methods are checked.
This cops checks for parentheses around the arguments in method
def arguments_without_parentheses?(node)
def arguments_without_parentheses?(node) node.arguments? && !parentheses?(node.arguments) end
def autocorrect(node)
def autocorrect(node) lambda do |corrector| if node.args_type? # offense is registered on args node when parentheses are unwanted corrector.replace(node.loc.begin, ' ') corrector.remove(node.loc.end) else args_expr = node.arguments.source_range args_with_space = range_with_surrounding_space(range: args_expr, side: :left) just_space = range_between(args_with_space.begin_pos, args_expr.begin_pos) corrector.replace(just_space, '(') corrector.insert_after(args_expr, ')') end end end
def missing_parentheses(node)
def missing_parentheses(node) location = node.arguments.source_range add_offense(node, location: location, message: MSG_MISSING) do unexpected_style_detected(:require_no_parentheses) end end
def on_def(node)
def on_def(node) args = node.arguments if require_parentheses?(args) if arguments_without_parentheses?(node) missing_parentheses(node) else correct_style_detected end elsif parentheses?(args) unwanted_parentheses(args) else correct_style_detected end end
def require_parentheses?(args)
def require_parentheses?(args) style == :require_parentheses || (style == :require_no_parentheses_except_multiline && args.multiline?) end
def unwanted_parentheses(args)
def unwanted_parentheses(args) add_offense(args, message: MSG_PRESENT) do unexpected_style_detected(:require_parentheses) end end