class RuboCop::Cop::Rails::BulkChangeTable
@see api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html<br>@see api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_table<br><br>end
end
t.string :nickname
t.string :name, null: false
change_table :users, bulk: false do |t|
def change
# When you don’t want to combine alter queries.
# good
end
end
t.string :nickname
t.string :name, null: false
change_table :users, bulk: true do |t|
def change
# good
end
end
t.string :nickname
t.string :name, null: false
change_table :users do |t|
def change
# bad
@example
end
# ADD ‘nickname` varchar(255)
# ALTER TABLE `users` ADD `name` varchar(255) NOT NULL,
end
t.string :nickname
t.string :name, null: false
change_table :users, bulk: true do |t|
def change
# good
end
# ALTER TABLE `users` ADD `nickname` varchar(255)
# ALTER TABLE `users` ADD `name` varchar(255) NOT NULL
add_column :users, :nickname, :string
add_column :users, :name, :string, null: false
def change
# bad
@example
this Cop ignores offenses.
If the adapter is not `mysql2` or `postgresql`,
in `config/database.yml` when the `Database` option is not set.
automatically detect an adapter from `development` environment
the PostgreSQL (5.2 later) adapter; thus it will
The `bulk` option is only supported on the MySQL and
ALTER TABLE statement combining multiple column alterations.
This option causes the migration to generate a single
to use `change_table` with `bulk: true` instead.
If combinable queries are detected, it suggests to you
This Cop checks whether alter queries are combinable.
def add_offense_for_alter_methods(node)
-
node
(RuboCop::AST::SendNode
) --
def add_offense_for_alter_methods(node) # arguments: [{(sym :table)(str "table")} ...] table_node = node.arguments[0] return unless table_node.is_a? RuboCop::AST::BasicLiteralNode message = format(MSG_FOR_ALTER_METHODS, table: table_node.value) add_offense(node, message: message) end
def add_offense_for_change_table(node)
-
node
(RuboCop::AST::SendNode
) --
def add_offense_for_change_table(node) add_offense(node, message: MSG_FOR_CHANGE_TABLE) end
def combinable_alter_methods
def combinable_alter_methods case database when MYSQL COMBINABLE_ALTER_METHODS + MYSQL_COMBINABLE_ALTER_METHODS when POSTGRESQL COMBINABLE_ALTER_METHODS + POSTGRESQL_COMBINABLE_ALTER_METHODS end end
def combinable_transformations
def combinable_transformations case database when MYSQL COMBINABLE_TRANSFORMATIONS + MYSQL_COMBINABLE_TRANSFORMATIONS when POSTGRESQL COMBINABLE_TRANSFORMATIONS + POSTGRESQL_COMBINABLE_TRANSFORMATIONS end end
def database
def database cop_config['Database'] || database_from_yaml end
def database_from_yaml
def database_from_yaml return nil unless database_yaml case database_yaml['adapter'] when 'mysql2' MYSQL when 'postgresql' POSTGRESQL end end
def database_yaml
def database_yaml return nil unless File.exist?('config/database.yml') yaml = YAML.load_file('config/database.yml') return nil unless yaml.is_a? Hash config = yaml['development'] return nil unless config.is_a?(Hash) config rescue Psych::SyntaxError nil end
def include_bulk_options?(node)
-
node
(RuboCop::AST::SendNode
) -- (send nil? :change_table ...)
def include_bulk_options?(node) # arguments: [{(sym :table)(str "table")} (hash (pair (sym :bulk) _))] options = node.arguments[1] return false unless options options.hash_type? && options.keys.any? { |key| key.sym_type? && key.value == :bulk } end
def on_def(node)
def on_def(node) return unless support_bulk_alter? return unless MIGRATION_METHODS.include?(node.method_name) return unless node.body recorder = AlterMethodsRecorder.new node.body.each_child_node(:send) do |send_node| if combinable_alter_methods.include?(send_node.method_name) recorder.process(send_node) else recorder.flush end end recorder.offensive_nodes.each { |n| add_offense_for_alter_methods(n) } end
def on_send(node)
def on_send(node) return unless support_bulk_alter? return unless node.command?(:change_table) return if include_bulk_options?(node) return unless node.block_node send_nodes = node.block_node.body.each_child_node(:send).to_a transformations = send_nodes.select do |send_node| combinable_transformations.include?(send_node.method_name) end add_offense_for_change_table(node) if transformations.size > 1 end
def support_bulk_alter?
def support_bulk_alter? case database when MYSQL true when POSTGRESQL # Add bulk alter support for PostgreSQL in 5.2.0 # @see https://github.com/rails/rails/pull/31331 target_rails_version >= 5.2 else false end end