class RuboCop::Cop::Security::Open
URI.parse(something).open
IO.popen(something)
File.open(something)
# good
open(something)
# bad
@example
`URI#open` explicitly.
‘Kernel#open`. It would be better to use `File.open`, `IO.popen` or
a serious security risk by using variable input to the argument of
by prefixing a pipe symbol (e.g., `open(“| ls”)`). So, it may lead to
`Kernel#open` enables not only file access but also process invocation
This cop checks for the use of `Kernel#open`.
def composite_string?(node)
def composite_string?(node) interpolated_string?(node) || concatenated_string?(node) end
def concatenated_string?(node)
def concatenated_string?(node) node.send_type? && node.method?(:+) && node.receiver.str_type? end
def interpolated_string?(node)
def interpolated_string?(node) node.dstr_type? end
def on_send(node)
def on_send(node) open?(node) do |code| return if safe?(code) add_offense(node, location: :selector) end end
def safe?(node)
def safe?(node) if simple_string?(node) safe_argument?(node.str_content) elsif composite_string?(node) safe?(node.children.first) else false end end
def safe_argument?(argument)
def safe_argument?(argument) !argument.empty? && !argument.start_with?('|') end
def simple_string?(node)
def simple_string?(node) node.str_type? end