class RuboCop::Cop::Style::Attr
attr_reader :one, :two, :three
attr_accessor :something
# good
attr :one, :two, :three # behaves as attr_reader
attr :something, true
# bad - creates a single attribute accessor (deprecated in Ruby 1.9)
@example
Checks for uses of Module#attr.
def allowed_context?(node)
def allowed_context?(node) return false unless (class_node = node.each_ancestor(:class, :block).first) (!class_node.class_type? && !class_eval?(class_node)) || define_attr_method?(class_node) end
def autocorrect(corrector, node)
def autocorrect(corrector, node) attr_name, setter = *node.arguments node_expr = node.source_range attr_expr = attr_name.source_range remove = range_between(attr_expr.end_pos, node_expr.end_pos) if setter&.boolean_type? corrector.replace(node.loc.selector, replacement_method(node)) corrector.remove(remove) if remove end
def define_attr_method?(node)
def define_attr_method?(node) node.each_descendant(:def).any? { |def_node| def_node.method?(:attr) } end
def message(node)
def message(node) format(MSG, replacement: replacement_method(node)) end
def on_send(node)
def on_send(node) return unless node.command?(:attr) && node.arguments? # check only for method definitions in class/module body return if allowed_context?(node) message = message(node) add_offense(node.loc.selector, message: message) do |corrector| autocorrect(corrector, node) end end
def replacement_method(node)
def replacement_method(node) setter = node.last_argument if setter&.boolean_type? setter.true_type? ? 'attr_accessor' : 'attr_reader' else 'attr_reader' end end