class RuboCop::Cop::Style::ComparableClamp
x.clamp(low, high)
# good
end
x
else
high
elsif high < x
low
if x < low
# bad
[[x, low].max, high].min
# bad
@example
—-
1.clamp(3, 1) # => min argument must be smaller than max argument (ArgumentError)
[1, [2, 3].max].min # => 1
—-
[source,ruby]
When these are variables, it is not possible to determine which is the minimum and maximum:
Because ‘ArgumentError` occurs if the minimum and maximum of `clamp` arguments are reversed.
This cop supports autocorrection for `if/elsif/else` bad style only.
Enforces the use of `Comparable#clamp` instead of comparison by minimum and maximum.
def autocorrect(corrector, node, prefer)
def autocorrect(corrector, node, prefer) if node.elsif? corrector.insert_before(node, "else\n") corrector.replace(node, "#{indentation(node)}#{prefer}") else corrector.replace(node, prefer) end end
def min_condition?(if_condition, else_body)
def min_condition?(if_condition, else_body) lhs, op, rhs = *if_condition (lhs.source == else_body && op == :<) || (rhs.source == else_body && op == :>) end
def on_if(node)
def on_if(node) return unless if_elsif_else_condition?(node) if_body, elsif_body, else_body = *node.branches else_body_source = else_body.source if min_condition?(node.condition, else_body_source) min = if_body.source max = elsif_body.source else min = elsif_body.source max = if_body.source end prefer = "#{else_body_source}.clamp(#{min}, #{max})" add_offense(node, message: format(MSG, prefer: prefer)) do |corrector| autocorrect(corrector, node, prefer) end end
def on_send(node)
def on_send(node) return unless array_min_max?(node) add_offense(node, message: MSG_MIN_MAX) end