class RuboCop::Cop::Style::FileWrite
File.binwrite(filename, content)
# good
end
f.write(content)
File.open(filename, ‘wb’) do |f|
File.open(filename, ‘wb’).write(content)
# bad
## binary mode
@example
File.write(filename, content)
# good
end
f.write(content)
File.open(filename, ‘w’) do |f|
File.open(filename, ‘w’).write(content)
# bad
## text mode
@example
—-
end
f.write(*objects)
File.open(filename, ‘w’) do |f|
—-
[source,ruby]
static analysis does not know the contents of the splat argument:
and ‘File#write` (instance method). The following case will be allowed because
NOTE: There are different method signatures between `File.write` (class method)
Favor `File.(bin)write` convenience methods.
def evidence(node)
def evidence(node) file_open?(node) do |filename, mode| file_open_write?(node.parent) do |content| yield(filename, mode, content, node.parent) end end end
def file_open_write?(node)
def file_open_write?(node) content = send_write?(node) || block_write?(node) do |block_arg, lvar, write_arg| write_arg if block_arg == lvar end return false if content&.splat_type? yield(content) if content end
def heredoc?(write_node)
def heredoc?(write_node) write_node.block_type? && (first_argument = write_node.body.first_argument) && first_argument.respond_to?(:heredoc?) && first_argument.heredoc? end
def heredoc_range(first_argument)
def heredoc_range(first_argument) range_between( first_argument.loc.heredoc_body.begin_pos, first_argument.loc.heredoc_end.end_pos ) end
def on_send(node)
def on_send(node) evidence(node) do |filename, mode, content, write_node| message = format(MSG, write_method: write_method(mode)) add_offense(write_node, message: message) do |corrector| range = range_between(node.loc.selector.begin_pos, write_node.source_range.end_pos) replacement = replacement(mode, filename, content, write_node) corrector.replace(range, replacement) end end end
def replacement(mode, filename, content, write_node)
def replacement(mode, filename, content, write_node) replacement = "#{write_method(mode)}(#{filename.source}, #{content.source})" if heredoc?(write_node) first_argument = write_node.body.first_argument <<~REPLACEMENT.chomp #{replacement} #{heredoc_range(first_argument).source} REPLACEMENT else replacement end end
def write_method(mode)
def write_method(mode) mode.end_with?('b') ? :binwrite : :write end