class RuboCop::Cop::Lint::PercentStringArray
%w(foo bar)
# good
@example
%w(‘foo’, “bar”)
# bad
@example
rather than meant to be part of the resulting strings.
example, mistranslating an array of literals to percent string notation)
It is more likely that the additional characters are unintended (for
This cop checks for quotes and commas in %w, e.g. ‘%w(’foo’, “bar”)‘
def autocorrect(node)
def autocorrect(node) lambda do |corrector| node.values.each do |value| range = value.loc.expression match = range.source.match(TRAILING_QUOTE) corrector.remove_trailing(range, match[0].length) if match if range.source =~ LEADING_QUOTE corrector.remove_leading(range, 1) end end end end
def contains_quotes_or_commas?(node)
def contains_quotes_or_commas?(node) node.values.any? do |value| literal = value.children.first.to_s.scrub # To avoid likely false positives (e.g. a single ' or ") next if literal.gsub(/[^[[:alnum:]]]/, '').empty? QUOTES_AND_COMMAS.any? { |pat| literal =~ pat } end end
def on_array(node)
def on_array(node) process(node, '%w', '%W') end
def on_percent_literal(node)
def on_percent_literal(node) return unless contains_quotes_or_commas?(node) add_offense(node) end