class RuboCop::Cop::Style::MultipleComparison
foo if [‘a’, ‘b’, ‘c’].include?(a)
a = ‘a’
# good
foo if a == ‘a’ || a == ‘b’ || a == ‘c’
a = ‘a’
# bad
@example
`Array#include?‘ could be used instead to avoid code repetition.
This cop checks against comparing a variable with multiple items, where
def comparison?(node)
def comparison?(node) simple_comparison?(node) || nested_comparison?(node) end
def nested_comparison?(node)
def nested_comparison?(node) if node.or_type? node.node_parts.all? { |node_part| comparison? node_part } else false end end
def nested_variable_comparison?(node)
def nested_variable_comparison?(node) return false unless nested_comparison?(node) variables_in_node(node).count == 1 end
def on_if(node)
def on_if(node) return unless nested_variable_comparison?(node.condition) add_offense(node) end
def variable_name(node)
def variable_name(node) node.children[0] end
def variables_in_node(node)
def variables_in_node(node) if node.or_type? node.node_parts .flat_map { |node_part| variables_in_node(node_part) } .uniq else variables_in_simple_node(node) end end
def variables_in_simple_node(node)
def variables_in_simple_node(node) simple_double_comparison?(node) do |var1, var2| return [variable_name(var1), variable_name(var2)] end simple_comparison?(node) do |var| return [variable_name(var)] end [] end