class RuboCop::Cop::Style::TrailingCommaInBlockArgs
end
foo + bar
add do
# good
end
foo
add do |foo,|
# good
end
foo + bar
add do |foo, bar|
# good
end
foo + bar
add do |foo, bar,|
# bad
add { foo }
# good
add { |foo,| foo }
# good
add { |foo, bar| foo + bar }
# good
add { |foo, bar,| foo + bar }
# bad
@example
argument (such as ‘|key, _value|`).
This can be fixed by replacing the trailing comma with a placeholder
—-
#=> [[:foo, 1], [:bar, 2], [:baz, 3]]
{foo: 1, bar: 2, baz: 3}.map {|key| key }
# without a trailing comma
#=> [:foo, :bar, :baz]
{foo: 1, bar: 2, baz: 3}.map {|key,| key }
# with a trailing comma
—-
[source,ruby]
For example:
more parameters that are not used.
This cop is unsafe because a trailing comma can indicate there are
@safety
require a trailing comma.
that comma to be present. Blocks with more than one argument never
required. Blocks with only one argument and a trailing comma require
Checks whether trailing commas in block arguments are
def arg_count(node)
def arg_count(node) node.arguments.each_descendant(:arg, :optarg, :kwoptarg).to_a.size end
def argument_tokens(node)
def argument_tokens(node) tokens = processed_source.tokens_within(node) pipes = tokens.select { |token| token.type == :tPIPE } begin_pos, end_pos = pipes.map { |pipe| tokens.index(pipe) } tokens[begin_pos + 1..end_pos - 1] end
def last_comma(node)
def last_comma(node) argument_tokens(node).last end
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler # lambda literal (`->`) never has block arguments. return if node.send_node.lambda_literal? return unless useless_trailing_comma?(node) last_comma_pos = last_comma(node).pos add_offense(last_comma_pos) { |corrector| corrector.replace(last_comma_pos, '') } end
def trailing_comma?(node)
def trailing_comma?(node) argument_tokens(node).last.comma? end
def useless_trailing_comma?(node)
def useless_trailing_comma?(node) arg_count(node) > 1 && trailing_comma?(node) end