class RuboCop::Cop::Bundler::DuplicatedGem
end
gem ‘rubocop’, ‘~> 0.90.0’
else
gem ‘rubocop’, git: ‘github.com/rubocop/rubocop.git’
elsif ENV == ‘master’
gem ‘rubocop’, path: local
if Dir.exist?(local)
# good - conditional declaration
gem ‘rubocop’, groups: [:development, :test]
# good
end
gem ‘rubocop’
group :development, :test do
# good
end
gem ‘rubocop’
group :test do
end
gem ‘rubocop’
group :development do
# bad
gem ‘rubocop’
gem ‘rubocop’
# bad
@example
A Gem’s requirements should be listed only once in a Gemfile.
def conditional_declaration?(nodes)
def conditional_declaration?(nodes) parent = nodes[0].each_ancestor.find { |ancestor| !ancestor.begin_type? } return false unless parent&.type?(:if, :when) root_conditional_node = parent.if_type? ? parent : parent.parent nodes.all? { |node| within_conditional?(node, root_conditional_node) } end
def duplicated_gem_nodes
def duplicated_gem_nodes gem_declarations(processed_source.ast) .group_by(&:first_argument) .values .select { |nodes| nodes.size > 1 && !conditional_declaration?(nodes) } end
def on_new_investigation
def on_new_investigation return if processed_source.blank? duplicated_gem_nodes.each do |nodes| nodes[1..].each do |node| register_offense(node, node.first_argument.to_a.first, nodes.first.first_line) end end end
def register_offense(node, gem_name, line_of_first_occurrence)
def register_offense(node, gem_name, line_of_first_occurrence) line_range = node.loc.column...node.loc.last_column offense_location = source_range(processed_source.buffer, node.first_line, line_range) message = format( MSG, gem_name: gem_name, line_of_first_occurrence: line_of_first_occurrence ) add_offense(offense_location, message: message) end
def within_conditional?(node, conditional_node)
def within_conditional?(node, conditional_node) conditional_node.branches.compact.any? do |branch| branch == node || branch.child_nodes.include?(node) end end