class RuboCop::Cop::Style::DataInheritance
# => [Person, Data, (…)]
Person.ancestors
end
end
42
def age
Person = Data.define(:first_name, :last_name) do
# good
# => [Person, #<Class:0x000000010b4e14a0>, Data, (…)]
Person.ancestors
end
end
42
def age
class Person < Data.define(:first_name, :last_name)
# bad
@example
tree (e.g. return value of ‘Module#ancestors`) of the constant.
Autocorrection is unsafe because it will change the inheritance
@safety
Inheriting from `Data.define` adds a superfluous level in inheritance tree.
Checks for inheritance from `Data.define` to avoid creating the anonymous parent class.
def correct_parent(parent, corrector)
def correct_parent(parent, corrector) if parent.block_type? corrector.remove(range_with_surrounding_space(parent.loc.end, newlines: false)) elsif (class_node = parent.parent).body.nil? corrector.remove(range_for_empty_class_body(class_node, parent)) else corrector.insert_after(parent, ' do') end end
def on_class(node)
def on_class(node) return unless data_define?(node.parent_class) add_offense(node.parent_class) do |corrector| corrector.remove(range_with_surrounding_space(node.loc.keyword, newlines: false)) corrector.replace(node.loc.operator, '=') correct_parent(node.parent_class, corrector) end end
def range_for_empty_class_body(class_node, data_define)
def range_for_empty_class_body(class_node, data_define) if class_node.single_line? range_between(data_define.source_range.end_pos, class_node.source_range.end_pos) else range_by_whole_lines(class_node.loc.end, include_final_newline: true) end end