class RuboCop::Cop::Rails::OrderById
scope :chronological, -> { order(created_at: :asc) }
# good
scope :chronological, -> { order(primary_key => :asc) }
scope :chronological, -> { order(id: :asc) }
# bad
@example
bottlenecks and appropriate database indexes are added.
NOTE: Make sure the changed order column does not introduce performance
Use a timestamp column to order chronologically. As a bonus the intent is clearer.
to be in any particular order, despite often (incidentally) being chronological.
Don’t use the ‘id` column for ordering. The sequence of ids is not guaranteed
Checks for places where ordering by `id` column is used.
def offense_range(node)
def offense_range(node) range_between(node.loc.selector.begin_pos, node.source_range.end_pos) end
def on_send(node)
def on_send(node) add_offense(offense_range(node)) if order_by_id?(node) end