class RuboCop::Cop::Rails::Present
something if foo.present?
# good
something unless foo.blank?
# bad
# Converts usages of ‘unless blank?` to `if present?`
@example UnlessBlank: true (default)
foo.present?
# good
not foo.blank?
# bad
!foo.blank?
# bad
# Converts usages of `!blank?` to `present?`
@example NotBlank: true (default)
foo.present?
# good
foo != nil && !foo.empty?
# bad
!foo.nil? && !foo.empty?
# bad
# Converts usages of `!nil? && !empty?` to `present?`
@example NotNilAndNotEmpty: true (default)
to prevent interference between the autocorrection of the two cops.
context of `unless else` if `Style/UnlessElse` is enabled. This is
The configuration of `NotBlank` will not produce an offense in the
Interaction with `Style/UnlessElse`:
using `Object#present?` defined by Active Support.
Checks for code that can be written with simpler conditionals
def autocorrect(corrector, node)
def autocorrect(corrector, node) method_call, variable1 = unless_blank?(node) if method_call corrector.replace(node.loc.keyword, 'if') range = method_call.source_range else variable1, _variable2 = exists_and_not_empty?(node) || not_blank?(node) range = node.source_range end corrector.replace(range, replacement(variable1)) end
def on_and(node)
def on_and(node) return unless cop_config['NotNilAndNotEmpty'] exists_and_not_empty?(node) do |var1, var2| return unless var1 == var2 message = format(MSG_EXISTS_AND_NOT_EMPTY, prefer: replacement(var1), current: node.source) add_offense(node, message: message) do |corrector| autocorrect(corrector, node) end end end
def on_if(node)
def on_if(node) return unless cop_config['UnlessBlank'] return unless node.unless? return if node.else? && config.cop_enabled?('Style/UnlessElse') unless_blank?(node) do |method_call, receiver| range = unless_condition(node, method_call) msg = format(MSG_UNLESS_BLANK, prefer: replacement(receiver), current: range.source) add_offense(range, message: msg) do |corrector| autocorrect(corrector, node) end end end
def on_or(node)
def on_or(node) exists_and_not_empty?(node) do |var1, var2| return unless var1 == var2 add_offense(node, message: MSG_EXISTS_AND_NOT_EMPTY) do |corrector| autocorrect(corrector, node) end end end
def on_send(node)
def on_send(node) return unless cop_config['NotBlank'] not_blank?(node) do |receiver| message = format(MSG_NOT_BLANK, prefer: replacement(receiver), current: node.source) add_offense(node, message: message) do |corrector| autocorrect(corrector, node) end end end
def replacement(node)
def replacement(node) node.respond_to?(:source) ? "#{node.source}.present?" : 'present?' end
def unless_condition(node, method_call)
def unless_condition(node, method_call) if node.modifier_form? node.loc.keyword.join(node.source_range.end) else node.source_range.begin.join(method_call.source_range) end end