class RuboCop::Cop::Rails::RelativeDateConstant
end
end
1.week.since
def self.expired_at
class SomeClass
# good
end
end
EXPIRES.since
def self.expired_at
EXPIRES = 1.week
class SomeClass
# good
end
EXPIRED_AT = 1.week.since
class SomeClass
# bad
@example
This cop’s autocorrection is unsafe because its dependence on the constant is not corrected.
@safety
Because the relative date will be evaluated only once.
Checks whether constant value isn’t relative date.
def autocorrect(corrector, node)
def autocorrect(corrector, node) return unless node.casgn_type? scope, const_name, value = *node return unless scope.nil? indent = ' ' * node.loc.column new_code = ["def self.#{const_name.downcase}", "#{indent}#{value.source}", 'end'].join("\n#{indent}") corrector.replace(node, new_code) end
def message(method_name)
def message(method_name) format(MSG, method_name: method_name) end
def nested_relative_date(node, &callback)
def nested_relative_date(node, &callback) return if node.nil? || node.any_block_type? node.each_child_node do |child| nested_relative_date(child, &callback) end relative_date(node, &callback) end
def offense_range(name, value)
def offense_range(name, value) range_between(name.source_range.begin_pos, value.source_range.end_pos) end
def on_casgn(node)
def on_casgn(node) nested_relative_date(node) do |method_name| add_offense(node, message: message(method_name)) do |corrector| autocorrect(corrector, node) end end end
def on_masgn(node)
def on_masgn(node) lhs, rhs = *node return unless rhs&.array_type? lhs.children.zip(rhs.children).each do |(name, value)| next unless name.casgn_type? nested_relative_date(value) do |method_name| add_offense(offense_range(name, value), message: message(method_name)) do |corrector| autocorrect(corrector, node) end end end end
def on_or_asgn(node)
def on_or_asgn(node) relative_date_or_assignment(node) do |method_name| add_offense(node, message: format(MSG, method_name: method_name)) end end